-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command line tool to produce and print pairwise alignments. #739
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 95.66% // Head: 95.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 125 125
Lines 7239 7247 +8
Branches 507 504 -3
=======================================
+ Hits 6925 6933 +8
Misses 314 314
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/main/scala/com/fulcrumgenomics/personal/tfenne/PairwiseAlign.scala
Outdated
Show resolved
Hide resolved
) extends FgBioTool { | ||
|
||
override def execute(): Unit = { | ||
val aligner = Aligner(1, -4, -6, -1, mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scoring params are hard-coded. Nice to have them exposed on the command line.
|
||
println() | ||
println("Right Aligned:") | ||
right.paddedString().foreach(println) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have the alignment score, cigar, target start/end, query start/end printed too. The latter are useful for local and glocal.
@nh13 I don't disagree with you suggestions but don't have time to act on them. Shall we merge and can add those later if/when we want? |
0946a5a
to
50b51a8
Compare
50b51a8
to
2be4171
Compare
This is here mostly to review
Alignment.revcomped
and the associated tests. You're welcome to review the personal tool as well, but I may or may not take feedback there ;)